From 2aa7bda3cb21ce6c052b82e08bcab79a625d04f2 Mon Sep 17 00:00:00 2001
From: Weicao-CatilGrass <1992414357@qq.com>
Date: Sun, 31 May 2026 02:42:52 +0800
Subject: Enhance code quality across the entire codebase

---
 mling/src/cli/list.rs | 24 ++++++++++++------------
 mling/src/cli/read.rs |  9 ++++++---
 2 files changed, 18 insertions(+), 15 deletions(-)

(limited to 'mling/src/cli')

diff --git a/mling/src/cli/list.rs b/mling/src/cli/list.rs
index ac9a65f..a2a9434 100644
--- a/mling/src/cli/list.rs
+++ b/mling/src/cli/list.rs
@@ -78,44 +78,44 @@ pub(crate) fn render_installed(prev: ResultInstalledNamespaces) {
     match prev.option {
         StateListInstalledOptions::All => {
             print_list(
-                "Trusted".bright_green().bold().to_string(),
-                prev.trusted,
+                &"Trusted".bright_green().bold().to_string(),
+                &prev.trusted,
                 __renderer_inner_result,
             );
             print_list(
-                "Untrusted".bright_red().bold().to_string(),
-                prev.untrusted,
+                &"Untrusted".bright_red().bold().to_string(),
+                &prev.untrusted,
                 __renderer_inner_result,
             );
             print_list(
-                "Untagged".bright_black().bold().to_string(),
-                prev.untagged,
+                &"Untagged".bright_black().bold().to_string(),
+                &prev.untagged,
                 __renderer_inner_result,
             );
         }
         StateListInstalledOptions::OnlyTrusted => {
             print_list(
-                "Trusted".bright_green().bold().to_string(),
-                prev.trusted,
+                &"Trusted".bright_green().bold().to_string(),
+                &prev.trusted,
                 __renderer_inner_result,
             );
         }
         StateListInstalledOptions::OnlyUntrusted => {
             print_list(
-                "Untrusted".bright_red().bold().to_string(),
-                prev.untrusted,
+                &"Untrusted".bright_red().bold().to_string(),
+                &prev.untrusted,
                 __renderer_inner_result,
             );
         }
     }
 }
 
-fn print_list(title: String, list: Vec<String>, __renderer_inner_result: &mut RenderResult) {
+fn print_list(title: &str, list: &[String], __renderer_inner_result: &mut RenderResult) {
     if list.is_empty() {
         return;
     }
 
-    r_println!("{}", title);
+    r_println!("{title}");
 
     for (i, namespace) in (1..).zip(list.iter()) {
         r_println!("  {}. {}", i.to_string(), namespace.bold());
diff --git a/mling/src/cli/read.rs b/mling/src/cli/read.rs
index 82f8fd5..e51e78f 100644
--- a/mling/src/cli/read.rs
+++ b/mling/src/cli/read.rs
@@ -25,7 +25,8 @@ pub(crate) struct ResultBinaries {
 }
 
 #[chain]
-pub(crate) fn handle_target_dir_entry(_prev: ReadTargetDirEntry) -> Next {
+#[allow(unused_variables)]
+pub(crate) fn handle_target_dir_entry(entry: ReadTargetDirEntry) -> Next {
     match solve_current_dir() {
         Ok(solved) => {
             let dir = solved.target_dir;
@@ -36,7 +37,8 @@ pub(crate) fn handle_target_dir_entry(_prev: ReadTargetDirEntry) -> Next {
 }
 
 #[chain]
-pub(crate) fn handle_workspace_root_entry(_prev: ReadWorkspaceRootEntry) -> Next {
+#[allow(unused_variables)]
+pub(crate) fn handle_workspace_root_entry(entry: ReadWorkspaceRootEntry) -> Next {
     match solve_current_dir() {
         Ok(solved) => {
             let dir = solved.workspace_root;
@@ -47,7 +49,8 @@ pub(crate) fn handle_workspace_root_entry(_prev: ReadWorkspaceRootEntry) -> Next
 }
 
 #[chain]
-pub(crate) fn handle_binaries_entry(_prev: ReadBinariesEntry) -> Next {
+#[allow(unused_variables)]
+pub(crate) fn handle_binaries_entry(entry: ReadBinariesEntry) -> Next {
     match solve_current_dir() {
         Ok(solved) => {
             let binaries = solved.binaries;
-- 
cgit